Add libc++ support for non-MacOS #1666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You'll want to rebase this on top of #1673 |
Contributor
Author
|
This commit would make #1673 obsolete (or that was my line of thinking). But it you prefer both changes in one PR I can do that |
Contributor
|
I mean, you're adding an additional clause to a line that no longer has a reason to exist, so I'd prefer it just gets removed. You're welcome to fold the two together into this PR instead. |
mpilman
force-pushed
the
features/clang+libc++
branch
from
16c4648 to
eb0b20b
Compare
mpilman
force-pushed
the
features/clang+libc++
branch
from
eb0b20b to
25618c2
Compare
Contributor
Author
|
Done - rebased on master and removed all changes to code (so this is a cmake-only change now) |
alexmiller-apple
requested review from
alexmiller-apple
and removed request for
AlvinMooreSr
alexmiller-apple
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small cmake change that allows FDB to be built with clang+libc++ on Linux. Clang and libstc++ seems to be currently broken, but I didn't want to enforce libc++ with clang, instead I think we should fix this so I created #1665 for this.