Export libfdb c #1636
Export libfdb c #1636
Conversation
|
It would be nice if this made it into 6.1. Please bear with me while I figure out how to make a pull request to 6.1 |
build/cmake/centos6-test/Dockerfile
Outdated
| FROM centos:6 | ||
|
|
||
| RUN yum install -y yum-utils upstart initscripts | ||
| RUN yum install -y yum-utils upstart initscripts cmake gcc |
There was a problem hiding this comment.
These should not install cmake or gcc. These images are meant to test whether FDB can be installed and whether it pulls in the correct dependencies.
You probably should install these in the test scripts
|
test this build |
|
test bindings |
AlvinMooreSr
left a comment
AlvinMooreSr
left a comment
There was a problem hiding this comment.
I agree with @mpilman that these runtime images should not install cmake or gcc.
|
@AlvinMooreSr I changed the tests so that the docker images do not come with cmake or gcc preinstalled. I also changed the target branch back to master since I realized 6.1 isn't being built with cmake anyway. PTAL |
|
We should probably also mark this as 6.2, since it fixes the install directory of the headers for the cmake generated client packages |
|
@AlvinMooreSr Is there anything preventing this from getting merged? |
4 participants
Fixes #1483