Build Docker Update #1476
Build Docker Update #1476
Conversation
build/Dockerfile
Outdated
| RUN adduser --disabled-password --gecos '' fdb && chown -R fdb /opt && chmod -R 0777 /opt | ||
| RUN adduser --comment '' fdb && chown -R fdb /opt && chmod -R 0777 /opt | ||
|
|
||
| USER fdb |
There was a problem hiding this comment.
I think the user fdb won't have write permissions in the /opt directory? Wouldn't it be better to move this command more towards the end?
There was a problem hiding this comment.
I am planning on removing this from the dockerfile completely in the next version.
| USER fdb | ||
|
|
||
| # wget of bintray without forcing UTF-8 encoding results in 403 Forbidden | ||
| RUN cd /opt/ &&\ |
There was a problem hiding this comment.
I would generally prefer to put dependencies into /usr/local. Otherwise we'll need to modify the PATH variable to make this work.
There was a problem hiding this comment.
We have a need to be able to install multiple versions such that the boost root directory: ie boost_1_67 would need to be included. For that reason, we use /opt rather than /usr/local (though that could also be done)
There was a problem hiding this comment.
That makes sense to me - and I guess having to pass -DBOOST_ROOT in the docker file is not a big deal
|
test this please |
…able scl tools Removed conditionals from docker-compose
Installed boto3 via pip
# Conflicts: # build/Dockerfile # build/docker-compose.yaml
|
test this please |
2 participants
Updated the build docker file to be Centos-based