Updated CMake PRB #1463
Updated CMake PRB #1463
Conversation
…for source because of bug within cpack
|
There is a I would suggest we simply switch to this new docker image. I would also be willing to maintain this. |
|
test this please |
|
@mpilman We are currently considering using those files for 6.2 (master) but will continue to use our existing docker for our current release. |
|
gotcha - makes sense |
|
test this please |
|
test this please |
1 similar comment
|
test this please |
Switched docker image to version including file so that cpack will work
mpilman
left a comment
mpilman
left a comment
There was a problem hiding this comment.
LGTM - added two comments but nothing that I think is too important. So you should decide whether you want to change anything.
build/docker-compose.yaml
Outdated
| volumes: | ||
| - ..:/foundationdb | ||
| working_dir: /foundationdb | ||
| - ..:/__this_is_some_very_long_name_dir_that_is_needed_to_fix_a_bug_with_cpack__/foundationdb |
There was a problem hiding this comment.
small correction: this is not a bug in cpack but an issue with RPM debug packages. But I don't think it matters too much
build/docker-compose.yaml
Outdated
| snapshot-cmake: &snapshot-cmake | ||
| <<: *build-setup | ||
| command: bash -c 'if [ -f CMakeLists.txt ]; then mkdir -p "$${BUILD_DIR}" && cd "$${BUILD_DIR}" && cmake .. && make -j "$${MAKEJOBS}"; fi' | ||
| command: bash -c 'if [ -f CMakeLists.txt ]; then mkdir -p "$${BUILD_DIR}" && cd "$${BUILD_DIR}" && cmake -DINSTALL_TARGET=RPM -DFDB_RELEASE=0 -DUSE_VALGRIND=0 /__this_is_some_very_long_name_dir_that_is_needed_to_fix_a_bug_with_cpack__/foundationdb && make -j "$${MAKEJOBS}" packages preinstall && cpack; fi' |
There was a problem hiding this comment.
I don't think these cmake arguments are necessary. I don't know what INSTALL_TARGET does (this is not in the source code). FDB_RELEASE and USE_VALGRING are set to OFF by default - so passing them here doesn't do anything.
There was a problem hiding this comment.
Use only to allow others to easily see some of the major build options
2 participants
Updated build images
Added support for running cpack and mounted source directory using very long directory name because of bug with cpack