Skip to content

Improve Python KeySelector representation #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ajbeamon merged 1 commit into from
Apr 1, 2019
Merged

Improve Python KeySelector representation #1385

ajbeamon merged 1 commit into from
Apr 1, 2019

Conversation

@cdonati
Copy link
Contributor

@cdonati cdonati commented Mar 31, 2019

Python 2 resolves escape characters when printing byte strings, which doesn't seem useful in this context.

I replaced __str__ since it defaults to __repr__ and the change should be suitable for both cases.

Old behavior:

>>> fdb.KeySelector(b'hi\n', False, 0.0)
<fdb.impl.KeySelector object at 0x7fec2963bed0>
>>> print(fdb.KeySelector(b'hi\n', False, 0.0))
KeySelector(hi
, False, 0)

New behavior:

>>> fdb.KeySelector(b'hi\n', False, 0.0)
KeySelector('hi\n', False, 0.0)
>>> print(fdb.KeySelector(b'hi\n', False, 0.0))
KeySelector('hi\n', False, 0.0)

@cdonati
Improve Python KeySelector representation
f1331db 
Python 2 resolves escape characters when printing byte strings,
which doesn't seem useful in this context.

I replaced __str__ since it defaults to __repr__ and the change
should be suitable for both cases.
@ajbeamon
Copy link
Contributor

ajbeamon commented Apr 1, 2019

@fdbbuild test this please

@ajbeamon ajbeamon merged commit 324438c into apple:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ajbeamon ajbeamon ajbeamon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdonati @ajbeamon