atomicReplace to preserve owner & permission info #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicReplace currently does not preserve the ownership and permission info, this fix will preserves the ownership and permission info - it fails the call if it is not able to do so.
ajbeamon
suggested changes
Mar 18, 2019
mpilman
reviewed
Mar 18, 2019
ajbeamon
approved these changes
Mar 19, 2019
etschannen
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
atomicReplace to preserve owner & permission info
etschannen
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
atomicReplace to preserve owner & permission info
alexmiller-apple
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
atomicReplace to preserve owner & permission info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atomicReplace call currently does not preserve the ownership and permission info, this fix will preserves the ownership and permission info - it fails the call if it is not able to do so.