Occasionally log a backtrace when the fast allocators allocates a new magazine #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… magazine to help track down memory leaks
ajbeamon
suggested changes
Mar 18, 2019
flow/Knobs.cpp
Outdated
| init( SLOWTASK_PROFILING_LOG_BACKOFF, 2.0 ); | ||
|
|
||
| init( RANDOMSEED_RETRY_LIMIT, 4 ); | ||
| init( FAST_ALLOC_LOGGING_CHANCE, (128<<10)/10000000.0 ); //one backtrace every 10MB |
Contributor
There was a problem hiding this comment.
Should we make the magazine size a knob? Or at the very least, we could change this knob to 10e6 (or 10e-6) and then move the magazine size constant to FastAlloc.cpp in order to limit its spread.
Co-Authored-By: etschannen <[email protected]>
ajbeamon
approved these changes
Mar 18, 2019
etschannen
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
Occasionally log a backtrace when the fast allocators allocates a new magazine
etschannen
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
Occasionally log a backtrace when the fast allocators allocates a new magazine
alexmiller-apple
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
Occasionally log a backtrace when the fast allocators allocates a new magazine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help track down memory leaks which involve fast allocated memory.