Increased the GRV client batch size #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mits related to the number of transactions started in a batch
ajbeamon
reviewed
Mar 18, 2019
fdbserver/Knobs.cpp
Outdated
| init( START_TRANSACTION_BATCH_QUEUE_CHECK_INTERVAL, 0.001 ); | ||
| init( START_TRANSACTION_MAX_TRANSACTIONS_TO_START, 10000 ); | ||
| init( START_TRANSACTION_MAX_BUDGET_SIZE, 20 ); // Currently set to match CLIENT_KNOBS->MAX_BATCH_SIZE | ||
| init( START_TRANSACTION_MAX_TRANSACTIONS_TO_START, 500000 ); |
Contributor
There was a problem hiding this comment.
Why was MAX_TRANSACTIONS_TO_START increased?
fdbserver/Knobs.cpp
Outdated
| init( START_TRANSACTION_MAX_TRANSACTIONS_TO_START, 10000 ); | ||
| init( START_TRANSACTION_MAX_BUDGET_SIZE, 20 ); // Currently set to match CLIENT_KNOBS->MAX_BATCH_SIZE | ||
| init( START_TRANSACTION_MAX_TRANSACTIONS_TO_START, 500000 ); | ||
| init( START_TRANSACTION_MAX_BUDGET_SIZE, 1000 ); // Currently set to match CLIENT_KNOBS->MAX_BATCH_SIZE |
Contributor
There was a problem hiding this comment.
A budget of 1000 is pretty big. I can understand why that might be beneficial when batch sizes are 1000, but I wonder if this could also sometimes lead to trouble.
…ough, and then pay back what was over the limit in the next update
ajbeamon
approved these changes
Mar 18, 2019
etschannen
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
Increased the GRV client batch size
etschannen
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
Increased the GRV client batch size
alexmiller-apple
pushed a commit
to etschannen/foundationdb
that referenced
this pull request
Mar 26, 2019
Increased the GRV client batch size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.