Skip to content

Allow building a working Docker image when target architecture is arm64 - #12140

Merged
jzhou77 merged 2 commits into
apple:mainfrom
gm42:feat/local-arm64-image-build-fixes
May 14, 2025
Merged

Allow building a working Docker image when target architecture is arm64#12140
jzhou77 merged 2 commits into
apple:mainfrom
gm42:feat/local-arm64-image-build-fixes

Conversation

@gm42

@gm42 gm42 commented May 9, 2025

Copy link
Copy Markdown
Collaborator

These changes introduce the possibility of building a working arm64 Docker image using build-images.sh; a few further changes were necessary to get it to work, but I am submitting in this PR the minimum changes necessary.

Code-Reviewer Section

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

@gm42
gm42 requested a review from johscheuer May 9, 2025 10:15
@gm42
gm42 force-pushed the feat/local-arm64-image-build-fixes branch from a44fda6 to 908b71d Compare May 9, 2025 10:17
@gm42

gm42 commented May 12, 2025

Copy link
Copy Markdown
Collaborator Author

cc @jzhou77

@gm42
gm42 requested a review from jzhou77 May 12, 2025 07:54
@johscheuer johscheuer closed this May 12, 2025
@johscheuer johscheuer reopened this May 12, 2025
@foundationdb-ci

foundationdb-ci commented May 12, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: 908b71d
  • Duration 0:26:01
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 12, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 908b71d
  • Duration 0:37:41
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 12, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: 908b71d
  • Duration 0:48:12
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 12, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 908b71d
  • Duration 0:58:34
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 12, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: 908b71d
  • Duration 0:59:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 12, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: 908b71d
  • Duration 1:34:20
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 12, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: 908b71d
  • Duration 1:36:56
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

johscheuer
johscheuer previously approved these changes May 13, 2025
View reviewed changes

@johscheuer johscheuer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍 Just one recommendation.

Comment thread packaging/docker/Dockerfile Resolved
@gm42
gm42 force-pushed the feat/local-arm64-image-build-fixes branch from 908b71d to c580f01 Compare May 13, 2025 10:02
@gm42
gm42 requested a review from johscheuer May 13, 2025 10:02
johscheuer
johscheuer approved these changes May 13, 2025
View reviewed changes

@johscheuer johscheuer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@johscheuer johscheuer closed this May 13, 2025
@johscheuer johscheuer reopened this May 13, 2025
@foundationdb-ci

foundationdb-ci commented May 13, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: c580f01
  • Duration 0:24:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 13, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: c580f01
  • Duration 0:37:57
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 13, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux CentOS 7

  • Commit ID: c580f01
  • Duration 0:48:34
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 13, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: c580f01
  • Duration 0:59:17
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 13, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: c580f01
  • Duration 1:00:42
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 13, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: c580f01
  • Duration 1:48:29
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

foundationdb-ci commented May 13, 2025

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: c580f01
  • Duration 1:51:25
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

jzhou77
jzhou77 approved these changes May 14, 2025
View reviewed changes
Comment thread packaging/docker/Dockerfile
mv "$file" /usr/bin/ || exit $?; \
done && \
mkdir -p /var/fdb/lib && \
for version in $FDB_LIBRARY_VERSIONS; do \

@jzhou77 jzhou77 May 14, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we produce arm binaries for older versions like ( '6.3.25' '7.1.57' '7.3.37') mentioned in the build-images.sh script. So by default, the build would fail. Other than that, the PR looks good to me. Maybe at certain point we can remove old versions in the script.

@gm42 gm42 May 16, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that, in fact in my build I only put 7.3.63 there; will remove old versions in a future PR.

@jzhou77
jzhou77 merged commit 0d9068e into apple:main May 14, 2025
@johscheuer johscheuer mentioned this pull request Oct 7, 2025
Merged
5 tasks done
@lexfrei lexfrei mentioned this pull request Feb 10, 2026
Open
3 of 10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johscheuer johscheuer johscheuer approved these changes
@jzhou77 jzhou77 jzhou77 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gm42 @foundationdb-ci @johscheuer @jzhou77