Skip to content

Commit f6dc3ba

Browse files
committed
Revert "debug seg fault"
This reverts commit fadcb08.
1 parent fadcb08 commit f6dc3ba

File tree

2 files changed

+0
-15
lines changed

2 files changed

+0
-15
lines changed

bindings/java/fdbJNI.cpp

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -492,15 +492,11 @@ class ExecuteOnLeave {
492492
};
493493

494494
void cpBytesAndLengthInner(uint8_t*& pByte, jint*& pLength, const uint8_t* data, const int& length) {
495-
fprintf(stderr, "Hfu5: cpBytesAndLengthInner start, length index %d, length %d, byte %p.\n", *pLength, length, pByte);
496-
fprintf(stdout, "Hfu5: cpBytesAndLengthInner start, length index %d, length %d, byte %p.\n", *pLength, length, pByte);
497495
*pLength = length;
498496
pLength++;
499497

500498
memcpy(pByte, data, length);
501499
pByte += length;
502-
fprintf(stderr, "Hfu5: cpBytesAndLengthInner end, length index %d, length %d, byte %p.\n", *pLength, length, pByte);
503-
fprintf(stdout, "Hfu5: cpBytesAndLengthInner end, length index %d, length %d, byte %p.\n", *pLength, length, pByte);
504500
}
505501

506502
void cpBytesAndLength(uint8_t*& pByte, jint*& pLength, const FDBKey& key) {
@@ -538,19 +534,12 @@ JNIEXPORT jobject JNICALL Java_com_apple_foundationdb_FutureMappedResults_Future
538534
int kvm_count = kvm.getRange.m_size;
539535

540536
const int totalLengths = 4 + kvm_count * 2;
541-
fprintf(stderr, "Hfu5: index %d, totalLengths %d.\n", i, totalLengths);
542-
fprintf(stdout, "Hfu5: index %d, totalLengths %d.\n", i, totalLengths);
543537

544538
int totalBytes = kvm.key.key_length + kvm.value.key_length + kvm.getRange.begin.key.key_length +
545539
kvm.getRange.end.key.key_length;
546-
547-
fprintf(stderr, "Hfu5: index %d, totalBytes %d.\n", i, totalBytes);
548-
fprintf(stdout, "Hfu5: index %d, totalBytes %d.\n", i, totalBytes);
549540
for (int i = 0; i < kvm_count; i++) {
550541
auto kv = kvm.getRange.data[i];
551542
totalBytes += kv.key_length + kv.value_length;
552-
fprintf(stdout, "Hfu5: index %d, totalBytes each %d, key: %d, v: %d.\n", i, totalBytes, kv.key_length, kv.value_length);
553-
fprintf(stderr, "Hfu5: index %d, totalBytes each %d, key: %d, v: %d.\n", i, totalBytes, kv.key_length, kv.value_length);
554543
}
555544

556545
jbyteArray bytesArray = jenv->NewByteArray(totalBytes);
@@ -598,9 +587,6 @@ JNIEXPORT jobject JNICALL Java_com_apple_foundationdb_FutureMappedResults_Future
598587
}
599588
}
600589
}
601-
fprintf(stderr, "Hfu5: Finish %d.\n", totalBytes);
602-
fprintf(stdout, "Hfu5: Finish %d.\n", totalBytes);
603-
604590
// After native arrays are released
605591
jobject mkv = jenv->CallStaticObjectMethod(
606592
mapped_key_value_class, mapped_key_value_from_bytes, (jbyteArray)bytesArray, (jintArray)lengthArray);

fdbserver/storageserver.actor.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3928,7 +3928,6 @@ ACTOR Future<GetMappedKeyValuesReply> mapKeyValues(StorageServer* data,
39283928
// since we always read the index, so always consider the index size
39293929
int indexSize = sizeof(KeyValueRef) + input.data[i + offset].expectedSize();
39303930
int size = indexSize + getMappedKeyValueSize(kvms[i]);
3931-
TraceEvent("Hfu5Add").detail("IndexSize", indexSize).detail("Index", i).detail("RecordSize", getMappedKeyValueSize(kvms[i]));
39323931
*remainingLimitBytes -= size;
39333932
result.data.push_back(result.arena, kvms[i]);
39343933
if (SERVER_KNOBS->STRICTLY_ENFORCE_BYTE_LIMIT && *remainingLimitBytes <= 0) {

0 commit comments

Comments
 (0)