Add trace event for role recruitment by CC

Zhe Wang · Zhe Wang · commit ef0a20c2d83f · 2021-08-16T15:24:31.000-05:00
diff --git a/fdbserver/ClusterController.actor.cpp b/fdbserver/ClusterController.actor.cpp
@@ -3580,10 +3580,12 @@ void clusterRecruitStorage(ClusterControllerData* self, RecruitStorageRequest re
 ACTOR Future<Void> clusterRecruitFromConfiguration(ClusterControllerData* self, RecruitFromConfigurationRequest req) {
 	// At the moment this doesn't really need to be an actor (it always completes immediately)
 	TEST(true); // ClusterController RecruitTLogsRequest
+	state double startTime = now();
 	loop {
 		try {
 			auto rep = self->findWorkersForConfiguration(req);
 			req.reply.send(rep);
+			TraceEvent("RecruitFromConfigurationDone", self->id).detail("WaitTime", now() - startTime);
 			return Void();
 		} catch (Error& e) {
 			if (e.code() == error_code_no_more_servers && self->goodRecruitmentTime.isReady()) {
@@ -3592,6 +3594,7 @@ ACTOR Future<Void> clusterRecruitFromConfiguration(ClusterControllerData* self,
 				return Void();
 			} else if (e.code() == error_code_operation_failed || e.code() == error_code_no_more_servers) {
 				// recruitment not good enough, try again
+				TraceEvent("RecruitFromConfigurationRetry", self->id).error(e);
 			} else {
 				TraceEvent(SevError, "RecruitFromConfigurationError", self->id).error(e);
 				throw; // goodbye, cluster controller
@@ -3605,10 +3608,12 @@ ACTOR Future<Void> clusterRecruitRemoteFromConfiguration(ClusterControllerData*
                                                          RecruitRemoteFromConfigurationRequest req) {
 	// At the moment this doesn't really need to be an actor (it always completes immediately)
 	TEST(true); // ClusterController RecruitTLogsRequest Remote
+	state double startTime = now();
 	loop {
 		try {
 			RecruitRemoteFromConfigurationReply rep = self->findRemoteWorkersForConfiguration(req);
 			req.reply.send(rep);
+			TraceEvent("RecruitRemoteFromConfigurationDone", self->id).detail("WaitTime", now() - startTime);
 			return Void();
 		} catch (Error& e) {
 			if (e.code() == error_code_no_more_servers && self->goodRemoteRecruitmentTime.isReady()) {
@@ -3617,6 +3622,7 @@ ACTOR Future<Void> clusterRecruitRemoteFromConfiguration(ClusterControllerData*
 				return Void();
 			} else if (e.code() == error_code_operation_failed || e.code() == error_code_no_more_servers) {
 				// recruitment not good enough, try again
+				TraceEvent("RecruitRemoteFromConfigurationRetry", self->id).error(e);
 			} else {
 				TraceEvent(SevError, "RecruitRemoteFromConfigurationError", self->id).error(e);
 				throw; // goodbye, cluster controller
