Don't pass non-pod to variadic function

sfc-gh-anoyes · sfc-gh-anoyes · commit 22e20db4bb08 · 2022-07-22T11:31:03.000-07:00
fdbserver/storageserver.actor.cpp:654:24: error: cannot pass object of non-trivial type 'const std::string' (aka 'const basic_string&lt;char, char_traits&lt;char&gt;, allocator&lt;char&gt;&gt;') through variadic function; call will abort at runtime [-Wnon-pod-varargs]

Just use fmt instead
diff --git a/fdbserver/storageserver.actor.cpp b/fdbserver/storageserver.actor.cpp
@@ -650,9 +650,9 @@ struct StorageServer {
 		PendingNewShard(uint64_t shardId, KeyRangeRef range) : shardId(format("%016llx", shardId)), range(range) {}
 
 		std::string toString() const {
-			return format("PendingNewShard: [ShardID]: %s [Range]: %s",
-			              this->shardId,
-			              Traceable<KeyRangeRef>::toString(this->range));
+			return fmt::format("PendingNewShard: [ShardID]: {} [Range]: {}",
+			                   this->shardId,
+			                   Traceable<KeyRangeRef>::toString(this->range));
 		}
 
 		std::string shardId;
