Repository navigation
Fix infinite recursion in graphdiff for non-torch graphs - #72
Merged
Merged
Conversation
Contributor
|
Thanks for the PR @darkdi! |
Contributor
Author
|
Right, that commit is unsigned. I need to get a signing key set up on this account first, then I will force push the same change signed. |
darkdi
force-pushed
the
graphdiff-recursion
branch
from
September 2, 2026 16:50
afc0ec1 to
4b4ba2e
Compare
Contributor
Author
|
Signed and force pushed, the commit shows as verified now. The earlier merge commit is gone from the branch, it only pulled main in and main had not moved since. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the Core AI implementation and the dispatcher below it are named _compute_op_diff_details, so the second one wins and its non-torch branch calls itself. Diffing a graph without torch_object ends in RecursionError. Renamed the first to sit beside _compute_torch_op_diff_details. Nothing imports tools/graphdiff and there are no tests for it, so say where you would want one.