Use container's environment when starting the init process #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kathryn Baldauf <[email protected]>
2 tasks
dcantah
approved these changes
Oct 13, 2025
katiewasnothere
added a commit
to katiewasnothere/container
that referenced
this pull request
Oct 14, 2025
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
added a commit
to katiewasnothere/container
that referenced
this pull request
Oct 14, 2025
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
added a commit
to apple/container
that referenced
this pull request
Oct 14, 2025
## Type of Change - [x] Bug fix ## Motivation and Context Required for builder to run correctly with bug fix in containerization here apple/containerization#329. Builder was previously not passing any environment variables when starting the initial process. ## Testing - [x] Tested locally --------- Signed-off-by: Kathryn Baldauf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue first described in apple/container#740.
Previously the initial process of the container was using vminitd's environment variables to find the target executable. This PR updates the code to use the container's configured environment for the initial process instead. The behavior of an exec in a container should be the same as before.