Handle warnings as errors #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Instead of an additional make target, can we just unify all the targets with:
What do you think? |
Contributor
Author
|
I do not mind, but this would make building with warnings allowed less convenient. @dcantah Do you have a preference? |
dkovba
force-pushed
the
dkovba/warnings-as-errors
branch
from
61bdb89 to
53c5da6
Compare
Contributor
|
Michael's idea is fine with me. It'll hopefully be rare enough (meaning the need to build with warnings) that it won't matter for ergonomics much. |
dkovba
force-pushed
the
dkovba/warnings-as-errors
branch
from
53c5da6 to
315c881
Compare
crosbymichael
approved these changes
Aug 28, 2025
dkovba
added a commit
to apple/container
that referenced
this pull request
Sep 10, 2025
To handle warnings as errors when building, use make. To allow warnings, use make WARNINGS_AS_ERRORS=false test. Also see apple/containerization#271.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle warnings as errors when building, use
make. To allow warnings, usemake WARNINGS_AS_ERRORS=false test.Also see apple/container#535.