Add a way to detect if a process' io has completed #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Ramani <[email protected]>
adityaramani
commented
Jun 12, 2025
dcantah
reviewed
Jun 12, 2025
dcantah
reviewed
Jun 12, 2025
dcantah
reviewed
Jun 12, 2025
dcantah
reviewed
Jun 12, 2025
dcantah
reviewed
Jun 12, 2025
Contributor
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
Looks great! Couple comments
dcantah
reviewed
Jun 13, 2025
Signed-off-by: Aditya Ramani <[email protected]>
adityaramani
force-pushed
the
io-wait
branch
3 times, most recently
from
e3b710d to
cd642fb
Compare
Signed-off-by: Aditya Ramani <[email protected]>
dcantah
approved these changes
Jun 13, 2025
crosbymichael
approved these changes
Jun 13, 2025
adityaramani
added a commit
to apple/container
that referenced
this pull request
Jun 16, 2025
Implements a way for the CLI to wait until the IO streams from the SandboxService have been drained before closing them. Follows the same pattern as apple/containerization#110 This change also performs some cleanup in the `SandboxService.startProcess` method - splitting the code paths to handle the init process and an exec'd process into two different private methods to make easier reading --------- Signed-off-by: Aditya Ramani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new private method
waitIoCompleteon theLinuxProcesstype.This method is called internally when the user calls
waitfor a process - and it tries to give the IO streams some time to clear their buffers.Internally, this method sets up an
AsyncStreamdown which an item is sent when the vsock connection for either stdout/stderr is terminated.We get this termination signal when the readability handler for the associated fd fires with a no available data.
Inside the guest - once we are done relaying the IO from the process into the socket connection, we close the socket fd which triggers the above.
All this logic is wrapped around a timeout of 3 seconds, just to ensure the method does not block forever.