-
Notifications
You must be signed in to change notification settings - Fork 584
Replace scattered defaults subcommands with system property.
#604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
system property.
- Replaces `registry default` and `system dns default` subcommands with `system property`. - Users can use `system property ls` to see details about each supported default value. - `system property set` implements reasonable validation for all properties. - NOTE: Probing of the registry for `registry default set` was removed, which means users will find out about a botched setting when pulling or pushing.
- Updated all documentation to use the new property commands instead of macOS defaults or individual default subcommands.
7c4815e to
9c1da8a
Compare
| } | ||
| DefaultsStore.set(value: value, key: key) | ||
| case .defaultBuilderImage, .defaultInitImage: | ||
| guard (try? Reference(path: value)) != nil else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be (try? Reference.parse(value)) != nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
adityaramani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had one comment - rest looks good
- Use the correct reference constructor. - Fix missing DefaultsStore set for kernel URL.
commit 449f1d2 Author: J Logan <[email protected]> Date: Tue Sep 16 13:37:55 2025 -0700 Replace scattered defaults subcommands with `system property`. (apple#604) Common subcommands for all defaults. - Closes apple#384. - Replaces `registry default` and `system dns default` subcommands with `system property`. - Users can use `system property ls` to see details about each supported default value. - `system property set` implements reasonable validation for all properties. - NOTE: Probing of the registry for `registry default set` was removed, which means users will find out about a botched setting when pulling or pushing. - Updates docs. ## Type of Change - [ ] Bug fix - [x] New feature - [x] Breaking change - [x] Documentation update ## Motivation and Context See apple#384. ## Testing - [x] Tested locally - [x] Added/updated tests - [x] Added/updated docs commit 386fd87 Author: Kathryn Baldauf <[email protected]> Date: Tue Sep 16 10:52:08 2025 -0700 Enumerate using relative paths to avoid mismatch with symlink resolution of special paths like /tmp (apple#613) ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation update ## Motivation and Context Fixes apple#588. This PR changes the archiver compression file enumeration to use the [enumerator(atPath:)](https://developer.apple.com/documentation/foundation/filemanager/enumerator(atpath:)) version. This version returns relative paths instead of full file paths from the filesystem. /tmp is symlinked to /private/tmp and some swift packages will handle that path differently. While a call to Foundation's `URL.resolvingSymlinksInPath()` will return "/tmp", a call to `FileManager.enumerator(at:)` will return "/private/tmp". This difference causes a container image build to fail when the user is using a path under /tmp or other special case paths as the context directory. ## Testing - [x] Tested locally - [x] Added/updated tests - [ ] Added/updated docs Signed-off-by: Kathryn Baldauf <[email protected]> commit 79cc363 Author: J Logan <[email protected]> Date: Tue Sep 16 10:14:14 2025 -0700 Relocates API server to Helpers, service to Services. (apple#616) - Closes apple#615. Improves project organization. Separates service so it can be tested and used separately from the executable target. No functional changes. commit a54be36 Author: J Logan <[email protected]> Date: Mon Sep 15 11:27:51 2025 -0700 Add `--labels` for networks. (apple#600) - Closes apple#557. - Breaking change: removes `.upToNextOption` for labels on volumes as this is not what is done for containers, and it forces the argument to precede the options if a label is supplied, which is non-intuitive. ## Type of Change - [ ] Bug fix - [x] New feature - [x] Breaking change - [x] Documentation update ## Motivation and Context Consistent features and UX across managed resources. ## Testing - [x] Tested locally - [x] Added/updated tests - [x] Added/updated docs
Common subcommands for all defaults.
registry defaultandsystem dns defaultsubcommands withsystem property.system property lsto see details about each supported default value.system property setimplements reasonable validation for all properties.registry default setwas removed, which means users will find out about a botched setting when pulling or pushing.Type of Change
Motivation and Context
See #384.
Testing