Uniform support for --platform, --os, --arch.
#545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Needs a |
jglogan
force-pushed
the
users/jglogan/cli-platform
branch
from
39a1c58 to
f0bddec
Compare
dcantah
approved these changes
Aug 27, 2025
jglogan
force-pushed
the
users/jglogan/cli-platform
branch
from
40f4d36 to
a3b4852
Compare
egernst
approved these changes
Aug 27, 2025
- Ensure `create`, `run`, `build`, `image pull`, and `image save` have consistent options, option order, and help messages. - Accept comma-separated lists in `container build`. - Deduplicate the final platform list in `container build`.
jglogan
force-pushed
the
users/jglogan/cli-platform
branch
from
a3b4852 to
679ea01
Compare
jglogan
force-pushed
the
users/jglogan/cli-platform
branch
from
677d473 to
15e49ff
Compare
dcantah
approved these changes
Aug 27, 2025
3 tasks
jglogan
added a commit
to jglogan/container
that referenced
this pull request
Sep 10, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container run/container createshould support a--platform=<OS>/<ARCH>flag #231.container create,container run,container build,container image pull, andcontainer image saveaccept the three options.container buildnow processes comma-separated lists for--platform,--arch, and--os. It first checks--platform, assembling the union of all platform values. If that set is non-empty, the builder builds the values in the set. Otherwise, the set consists of all combinations of the specified architecture and os values, finally defaulting tolinuxand the host architecture if no options are provided.--platformoption over--archand--oswhen both are specified.--osdefaults tolinux, and--archdefaults to the host architecture.container build.