Native Builder: DiffKey and Differ Procol #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlan0
force-pushed
the
native-build-differ
branch
4 times, most recently
from
b16a605 to
298f486
Compare
Tests/NativeBuilderTests/ContainerBuildSnapshotterTests/BinaryPathTests.swift
Outdated
Show resolved
Hide resolved
wlan0
force-pushed
the
native-build-differ
branch
from
298f486 to
6c06d63
Compare
wlan0
force-pushed
the
native-build-differ
branch
from
6c06d63 to
08c93bd
Compare
Comment on lines
+295
to
+299
| // Alternative test: ensure original path with valid UTF-8 round-trips correctly | ||
| let utf8Path = BinaryPath(string: "/usr/local/bin") | ||
| let utf8Data = try encoder.encode(utf8Path) | ||
| let utf8Decoded = try decoder.decode(BinaryPath.self, from: utf8Data) | ||
| #expect(utf8Path == utf8Decoded) |
Contributor
There was a problem hiding this comment.
I think this is covered already in CodableWithValidUTF8
Comment on lines
+329
to
+336
| @Test func PathWithMultipleSlashes() { | ||
| let path = BinaryPath(string: "//usr///local//bin//") | ||
| let components = path.components | ||
| #expect(components.count == 3) | ||
| #expect(components[0].stringValue == "usr") | ||
| #expect(components[1].stringValue == "local") | ||
| #expect(components[2].stringValue == "bin") | ||
| } |
Contributor
There was a problem hiding this comment.
I think this is already covered in PathComponents
katiewasnothere
approved these changes
Aug 12, 2025
Contributor
katiewasnothere
left a comment
katiewasnothere
left a comment
There was a problem hiding this comment.
A couple minor comments on the tests, otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
Differwith methods:It also introduces
DiffKey, which is a MerkeTree based key for fast diff computations between two dirs