Optionally resolve wrapper index to single-platform manifest based on com.apple.containerization.index.indirect annotation
#397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon an indirect manifest, return the original manifest instead of the wrapper index. This ensures that the manifest returned by 'container image inspect' matches the original image digest.
- Add displayDigest() method to ClientImage to return original manifest digest for single-manifest images instead of wrapper index digest - Update container image list (both normal and verbose modes) to use displayDigest() for consistent digest display - Ensures digest shown in image list matches the digest from image inspect Related to issue apple#212 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
stevapple
force-pushed
the
fix-issue-212
branch
4 times, most recently
from
721fb07 to
ded9c56
Compare
This will help us unify the implementation of indirect image resolution.
Contributor
Author
|
@adityaramani may you review the pull if you have time? |
adityaramani
reviewed
Aug 4, 2025
adityaramani
reviewed
Aug 4, 2025
stevapple
force-pushed
the
fix-issue-212
branch
from
859ccc5 to
766c6aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
package func resolved()onClientImagethat makes use of the newcom.apple.containerization.index.indirectannotation to identify and resolve wrapper indices created by Containerization;container image listwith the one of the resolved manifest;container image inspectif the index is a wrapper.Fixes #212, as shown with the following local result:
