Skip to content

Conversation

@justinyaodu
Copy link
Contributor

When users run commands with a debug build, they see a warning that debug builds may have worse performance. Add instructions to BUILDING.md so that users who wish to install from source know how to get a release build.

I tested the command locally and ran container --version to verify that I got a release build.

Or to install a release build, with better performance than the debug build:

```bash
BUILD_CONFIGURATION=release make install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinyaodu Thanks for the contribution! This makes sense.

Since it's necessary for BUILD_CONFIGURATION to be defined consistently across targets, could you amend this so it shows both commands?

BUILD_CONFIGURATION=release make all test integration
BUILD_CONFIGURATION=release make install

Of course you can set BUILD_CONFIGURATION in the environment; you can also set these as make variables (putting BUILD_CONFIGURATION after make) instead of using the environment. We can assume a certain amount of developer expertise with make and variables, just show the release version of these two commands, and let developers figure out what suits them best.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you mention it, I actually did get confused by this. At some point I ran make all with BUILD_CONFIGURATION=release and make install without it, and still got the debug build. Thanks for the great suggestion! I have updated the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@justinyaodu justinyaodu requested a review from jglogan July 27, 2025 17:04
Or to install a release build, with better performance than the debug build:

```bash
BUILD_CONFIGURATION=release make install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@jglogan jglogan merged commit 728527b into apple:main Jul 30, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants