define JSONDecoder() outside of for loop in load() #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-wright
force-pushed
the
jsondecoder
branch
from
2d1dccf to
a10fc13
Compare
dcantah
approved these changes
Jun 12, 2025
Contributor
|
Thanks |
Contributor
|
Hi @elijah-wright could you rebase your PR? Sorry about that, I made a fix for the CI issue here #176 |
elijah-wright
force-pushed
the
jsondecoder
branch
from
a10fc13 to
14358f3
Compare
Signed-off-by: Elijah Wright <[email protected]>
elijah-wright
force-pushed
the
jsondecoder
branch
from
14358f3 to
c30f7a9
Compare
Contributor
Author
|
ok, I just rebased it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR defines a variable,
decoder, which represents theJSONDecoderclass, rather than doing it in the for loop inload()