Merged
Conversation
9 tasks
imurchie
reviewed
Mar 28, 2019
|
|
||
| async cleanProject () { | ||
| for (const scheme of [LIB_SCHEME, RUNNER_SCHEME]) { | ||
| const libScheme = _.toLower(this.platformName) === _.toLower(PLATFORM_NAME_TVOS) ? LIB_SCHEME_TV : LIB_SCHEME_IOS; |
Contributor
There was a problem hiding this comment.
Perhaps this equality check could be in a helper function (e.g., isTvOS) since it happens again and again, which might be able to be memoized.
Alternatively, it could be in a function like getSchemes
getSchemes () {
const isTvOS = _.toLower(this.platformName) === _.toLower(PLATFORM_NAME_TVOS);
const libScheme = isTvOS ? LIB_SCHEME_TV : LIB_SCHEME_IOS;
const runnerScheme = isTvOS ? RUNNER_SCHEME_TV : RUNNER_SCHEME_IOS;
return {
libScheme,
runnerScheme,
};
}| * Return the WDA object which appends existing xctest runner content | ||
| * @param {string} platformName - The name of platform | ||
| * @param {string} version - The Xcode SDK version of OS. | ||
| * @return {object} returns an runner object which has USE_PORT |
|
|
||
| /** | ||
| * Return the WDA object which appends existing xctest runner content | ||
| * @param {string} platformName - The name of platform |
|
|
||
| /** | ||
| * Return true if the platformName is tvOS | ||
| * @param {string} platformName The name of platorm |
Contributor
|
LGTM, just need to wait for the tests to pass |
mykola-mokhnach
approved these changes
Mar 29, 2019
imurchie
approved these changes
Mar 29, 2019
Member
Author
|
thanks for hard review for tvOS support! |
4 tasks
3 tasks
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* consider tvos * fix tvos support * override desiredCapConstraints * add name of arguments in docstring, tweak const name for ios * bump WDA * remove memorized, use [] style to add a object key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tvOSplatformtvOSschemexctestrunFilecap fortvOSOn appium/appium#12401 , I've attached an animation-gif of action for tvOS via Ruby client.