Add system logs broadcast feature#653
Merged
mykola-mokhnach merged 4 commits intoappium:masterfrom Apr 24, 2018
Merged
Conversation
jlipps
approved these changes
Apr 20, 2018
| } else { | ||
| log.debug('Established a new system logs listener web socket connection'); | ||
| } | ||
| this.logs.syslog.on('output', (logRecord) => { |
Member
There was a problem hiding this comment.
do we want to remove this event listener whenever we stop the logs broadcast?
Contributor
Author
There was a problem hiding this comment.
good catch. This has to be fixed for Android as well
jlipps
approved these changes
Apr 20, 2018
Member
jlipps
left a comment
jlipps
left a comment
There was a problem hiding this comment.
looks good. are there other places we might need to think about removing the listener? for example, what about during session stop? are we already stopping logs broadcast then?
Contributor
Author
|
Yes we do close all opened web sockets, so the listeners will be removed automatically, since they are attached to onClose event |
mykola-mokhnach
force-pushed
the
log_broadcast
branch
from
10caa21 to
a39efc7
Compare
4 tasks
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* Add system logs broadcast feature * Remove syslog listener when necessary * Remove the listener upon web socket close * Bump ios driver version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on appium-boneyard/appium-ios-driver#272