Add endpoints for screen recording support#609
Merged
imurchie merged 12 commits intoappium:masterfrom Jan 19, 2018
Merged
Conversation
imurchie
reviewed
Jan 18, 2018
| this._recentScreenRecordingPath = null; | ||
| } | ||
|
|
||
| const localPath = temp.path({prefix: 'appium', suffix: DEFAULT_EXT}); |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
shall I use tempdir.path instead? I find it a bit redundant, since I don't need a whole directory to be created, but rather just a single file
Contributor
There was a problem hiding this comment.
I would rather tall temporary file management be done in a single place, yes.
| log.errorAndThrow(`'${binaryName}' binary is not found in PATH. Make sure it is present on the system. ` + | ||
| `Check https://github.com/WPO-Foundation/xrecord for more details.`); | ||
| } | ||
| args.push('--quicktime', |
Contributor
There was a problem hiding this comment.
Both real device and simulator case have base arguments, so pushing is not necessary, in the same way as binaryName is handled.
let binaryName;
let args;
if (this.isRealDevice()) {
binaryName = REAL_DEVICE_BINARY;
// ...
args = {
'--quicktime',
`--id="${this.opts.device.udid}"`,
`--out="${localPath}"`,
`--force`,
};
// ...
} else {
binaryName = SIMULATOR_BINARY;
args = {
'simctl',
'io',
this.opts.device.udid,
'recordVideo',
};
// ...
}
Contributor
Author
There was a problem hiding this comment.
for me it is just a matter of style. You know how I like constants :)
Contributor
There was a problem hiding this comment.
But it is logically not a constant. :)
3 tasks
4 tasks
imurchie
approved these changes
Jan 19, 2018
khanayan123
pushed a commit
to khanayan123/appium-xcuitest-driver
that referenced
this pull request
May 10, 2021
* Initial implementation of Simulator screen recorder * Apply minor fixes * Tune timeouts * Tune regexp * Fix setting options * Add tests and do basic refactoring * Update appium-support version * Address review comments * Tune the logic for Simulator recorder * Update functional test * Set proper defaults and tune timeout calculation * Tune error messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added primitives to support screen recording using simctl for Simulators and xrecord tool for real devices.
This PR depends on appium/appium-support#61