Skip to content

Add endpoints for lock/unlock#595

Closed
mykola-mokhnach wants to merge 5 commits intoappium:masterfrom
mykola-mokhnach:lock
Closed

Add endpoints for lock/unlock#595
mykola-mokhnach wants to merge 5 commits intoappium:masterfrom
mykola-mokhnach:lock

Conversation

@mykola-mokhnach
Copy link
Copy Markdown
Contributor

Do not merge this PR until appium/WebDriverAgent#21 is in

@mykola-mokhnach
Copy link
Copy Markdown
Contributor Author

Waiting until WDA submodule is bumped in order to merge this change

@imurchie
Copy link
Copy Markdown
Contributor

Have you rebased the WDA change so the tests can run?

@mykola-mokhnach
Copy link
Copy Markdown
Contributor Author

There is nothing to rebase yet. appium/WebDriverAgent#32 is not in the bundled WDA submodule

@imurchie
Copy link
Copy Markdown
Contributor

But the tests aren't going to run on the WDA change (appium/WebDriverAgent#32) until it has been rebased with the WDA master, and repushed to Github.

@mykola-mokhnach
Copy link
Copy Markdown
Contributor Author

My point is that it is better to do WDA updates in a separate PR, so we can carefully check tests and fix the stuff before it breaks our regression

@imurchie
Copy link
Copy Markdown
Contributor

Yes. I agree completely.

My point is that the WDA code itself has tests, and they aren't getting run because Travis is broken. And they aren't getting run on CircleCI because they don't have the configuration code yet.

That configuration code is in master of our WDA fork. So the PRs need to be rebased with that and repushed so builds on CircleCI get initiated. Without that, they will not get merged because we have no idea if they work.

@mykola-mokhnach
Copy link
Copy Markdown
Contributor Author

I'll recreate this PR. There are problems with submodule rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants