Add a possibility to retrieve battery info from real devices#164
Merged
mykola-mokhnach merged 1 commit intoappium:masterfrom May 7, 2018
Merged
Add a possibility to retrieve battery info from real devices#164mykola-mokhnach merged 1 commit intoappium:masterfrom
mykola-mokhnach merged 1 commit intoappium:masterfrom
Conversation
imurchie
reviewed
Apr 30, 2018
Contributor
imurchie
left a comment
imurchie
left a comment
There was a problem hiding this comment.
Does this work for emulated devices, too?
Contributor
Author
|
The documentation says it should |
4 tasks
imurchie
approved these changes
May 1, 2018
Contributor
Author
|
I'd like to add an integration test first after this functionality is present on the server side |
KazuCocoa
reviewed
May 1, 2018
| return await this.uiautomator2.jwproxy.command('/appium/device/battery_info', 'GET', {}); | ||
| const result = await this.uiautomator2.jwproxy.command('/appium/device/battery_info', 'GET', {}); | ||
| // Give it the same name as in iOS | ||
| result.state = result.status; |
KazuCocoa
approved these changes
May 2, 2018
mykola-mokhnach
force-pushed
the
battery_info
branch
from
e669320 to
6aac94b
Compare
mykola-mokhnach
force-pushed
the
battery_info
branch
from
d48ad56 to
de23d20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on appium/appium-uiautomator2-server#143