The spec seems to say that it should accept a DeviceRotation object, but their examples are sending x, y, and z values (https://github.com/SeleniumHQ/mobile-spec/blob/master/spec-draft.md#devicerotation). Not sure which is to be taken as correct.

DeviceRotation is the "name" of the object type, similarly to NetworkConnection objects. that name doesn't actually need to show up in the JSONWP though.

Ah. Ok. That needs to be reflected here, then.

Are we saying the post part should change like this?

POST: {command: 'setRotation', payloadParams: {required: ['rotation']}}

to :

POST: { command: 'setRotation', payloadParams: { unwrap: 'parameters', required: ['type'] } }

No. The spec says the payload should be something like

{"name": "rotation", "parameters": {"x": 0, "y": 0, "z": 0}}

So in the mjsonwp implementation here, it should be something like

payloadParams: {unwrap: 'parameters', required: ['x', 'y', 'z']}

updated mobile spec here

Looks good to me.

And thanks for fixing the spec!

@imurchie should i update the expected test hash?

Yes. Otherwise the tests will fail and we can't merge.

Thanks!