add reboot option for android emulator#6822
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@alizelzele we're moving away from having command line parameters in addition to capabilities. Things which are relevant for individual sessions should be capabilities only, not command line flags. So I think we should just document it in caps and avoid adding a |
|
This flag is for appium to kill emulator at end of each session and open a new wiped emulator at start of each session. It is much better if it is defined as command line parameter, instead of individual sessions. If we define it as a cap, one test can have it and kill the Emulator at the end, so all the test should have this parameter set to be able to open the emulator again (setting the I think setting it as a flag make sense in this case. |
|
OK, makes sense to me then. Ready to merge whenever the upstream functionality is available. |
|
@jlipps every other PR required for this functionality is already merged, but because of versions defined in |
|
great, thanks! |
|
@SrinivasanTarget This parameter should not be used as a capability, but as a Server flag. You are right, it should not be added as default capabilities. 😞 We even discussed it here, but it some how end up in documents. |
Proposed changes
If reboot option activated, it will always wipe data of emulator on start, and close emulator at the end. it is required for support reboot parameter for android
Types of changes
Checklist
Reviewers: @imurchie, @jlipps, ...