Skip to content

add reboot option for android emulator#6822

Merged
jlipps merged 1 commit intoappium:masterfrom
alizelzele:reboot-emulator
Sep 19, 2016
Merged

add reboot option for android emulator#6822
jlipps merged 1 commit intoappium:masterfrom
alizelzele:reboot-emulator

Conversation

@alizelzele
Copy link
Copy Markdown
Contributor

Proposed changes

If reboot option activated, it will always wipe data of emulator on start, and close emulator at the end. it is required for support reboot parameter for android

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Reviewers: @imurchie, @jlipps, ...

@triager
Copy link
Copy Markdown
Contributor

triager commented Sep 9, 2016

Can one of the admins verify this patch?

1 similar comment
@triager
Copy link
Copy Markdown
Contributor

triager commented Sep 9, 2016

Can one of the admins verify this patch?

@jlipps
Copy link
Copy Markdown
Member

jlipps commented Sep 12, 2016

@alizelzele we're moving away from having command line parameters in addition to capabilities. Things which are relevant for individual sessions should be capabilities only, not command line flags. So I think we should just document it in caps and avoid adding a --reboot flag.

@alizelzele
Copy link
Copy Markdown
Contributor Author

This flag is for appium to kill emulator at end of each session and open a new wiped emulator at start of each session. It is much better if it is defined as command line parameter, instead of individual sessions.

If we define it as a cap, one test can have it and kill the Emulator at the end, so all the test should have this parameter set to be able to open the emulator again (setting the avd name parameter will work too, but this way it will not close the emulator at the end, and of course will not wipe it).

I think setting it as a flag make sense in this case.

@jlipps
Copy link
Copy Markdown
Member

jlipps commented Sep 14, 2016

OK, makes sense to me then. Ready to merge whenever the upstream functionality is available.

@alizelzele
Copy link
Copy Markdown
Contributor Author

@jlipps every other PR required for this functionality is already merged, but because of versions defined in package.json it needs npm update to fetch the currect version..

@jlipps jlipps merged commit 9b7451d into appium:master Sep 19, 2016
@jlipps
Copy link
Copy Markdown
Member

jlipps commented Sep 19, 2016

great, thanks!

@SrinivasanTarget
Copy link
Copy Markdown
Member

SrinivasanTarget commented Sep 20, 2016

@jlipps @imurchie I didn't understand why --reboot is listed in both Server flags and default capabilities flag? Isn't it a duplicate? please clarify is there any other reason behind it.

@alizelzele
Copy link
Copy Markdown
Contributor Author

@SrinivasanTarget This parameter should not be used as a capability, but as a Server flag. You are right, it should not be added as default capabilities. 😞

We even discussed it here, but it some how end up in documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants