add support to set UiAutomator Congfigurator values#6561
add support to set UiAutomator Congfigurator values#6561imurchie merged 1 commit intoappium:masterfrom
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
|
||
| **"ignoreUnimportantViews"** - Boolean which sets whether Android devices should use `setCompressedLayoutHeirarchy()` which ignores all views which are marked IMPORTANT_FOR_ACCESSIBILITY_NO or IMPORTANT_FOR_ACCESSIBILITY_AUTO (and have been deemed not important by the system), in an attempt to make things less confusing or faster. | ||
|
|
||
| **"configurator"** - JSON string (example: `{"method":"setWaitForIdleTimeout","value":5000}`) which sets [UiAutomator Configurator](https://developer.android.com/reference/android/support/test/uiautomator/Configurator.html) timeouts and delays in Android devices. |
There was a problem hiding this comment.
any reason it couldn't just be a JSON object that gets sent rather than a JSON string?
There was a problem hiding this comment.
I think in http request, all params are treated as String. In client implementation, we could parse to JSON Object
|
👍 just squash please! |
|
It seems that because I merged from upstream master, the squash included some changes in other upstream commits. Is that OK? |
|
@truebit, no, this PR should contain only your changes! looks like you need to rebase on upstream master instead of merging from it |
|
sqash done as you said :) |
|
@imurchie You merged this PR, but left appium/appium-android-driver#153 unaccepted. without the left PR, it won't work. |
|
Yes. Once everyone is happy with that PR, it will be merged. This one is just documentation, and being slightly out of sync is not too much of a problem. Especially since the work will only be available to someone using the source code anyway, until we have time to release a new version. |
4 participants
Proposed changes
UiAutomator Configurator provides several methods to change its the configurations.
I have implemented them in appium using appium settings api
This is the overall PR for all other three PRs:
appium-android-driver
appium-android-bootstrap
java-client
I know there would be
appium-uiautomator2-serverandappium-uiautomator2-driverin upcoming versions. Since I used existing API, It would be OK for me to merge this feature to the new android server and driverTypes of changes
What types of changes does your code introduce to Appium?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
But according to android uiautomator fixed timeout bug in UiAutomatorBridge, the timeout in dynamic page still cannot be changed.
Maybe we need to recompile
uiautomator.jarto change the static final fieldTOTAL_TIME_TO_WAIT_FOR_IDLE_STATEfrom10 * 1000toConfigurator.getInstance().getWaitForIdleTimeout().That's a little more complexed, I have not tried that.
Reviewers: