This repository was archived by the owner on Aug 14, 2020. It is now read-only.
schema/types: translate between appc<->go arch tuples#668
Merged
squeed merged 1 commit intoappc:masterfrom Oct 25, 2016
Merged
Conversation
This commit introduces two helper functions to translate between appc and golang os/architecture labels.
s-urbaniak
approved these changes
Oct 24, 2016
Contributor
s-urbaniak
left a comment
s-urbaniak
left a comment
There was a problem hiding this comment.
Small comment, else LGTM, thanks!
| func ToGoOSArch(appcOs string, appcArch string) (goOs string, goArch string, goArchFlavor string, e error) { | ||
| tabularGoToAppc := map[appcArchTuple]goArchTuple{ | ||
| // {"linux", "aarch64_be"}: nil, | ||
| // {"linux", "armv7b"}: nil, |
Contributor
There was a problem hiding this comment.
Can we simply remove those?
Contributor
Author
There was a problem hiding this comment.
We can, this is here just to make explicit that there are two arch without a Go equivalent (future-proofing myself the next time I go over the list). I'd better leave this here or translate to a human-readable comment.
Contributor
Author
There was a problem hiding this comment.
As per OOB, keeping it there.
Contributor
Author
|
@jonboulle @squeed it looks like Travis got stuck on this, can anybody of you please re-trigger? |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces two helper functions to translate between
appc and golang os/architecture labels.
Closes #665