Repository navigation
Commit 2045a8b
committed
feat(remote): rn-iso ios --remote, a device that is not on this machine
The build stays here. The fingerprint, the shared cache and single-flight
builds are the reason rn-iso is fast and none of them care where the device
is, so `--remote` moves ONLY the device.
The seam already existed. DEFAULT_DEPS in commands/ios.ts is documented as
"the test seam. Every engine call goes through it", and five of its entries
are the whole device surface. Remote mode replaces those and nothing else,
so the local path is not refactored, every phase line is unchanged, and no
existing test moved.
engine/device-remote.ts supplies the replacements. The ordering property
survives with opposite mechanics: locally the Metro gate sits between a cheap
ensureOwnedDevice and a slow ensureBooted, and remote inverts which step is
expensive, so ensureOwnedDevice records intent only and the billable session
is created in ensureBooted, still after the gate.
The token never reaches disk. The connection profile under .rn-iso/ carries
routing only, per agent-device ADR 0007, and the token travels as an env var
on each child. state.json holds the session id alone, and eas simulator:get
re-reads the token when it is needed.
stop DESTROYS a remote session, which is the one exception to "stop never
deletes": a shut-down simulator costs nothing to keep, a cloud session bills
until its cap. A failed stop keeps the record and exits non-zero, matching
how a failed local teardown keeps its device record.
rn-iso does not drive metro prepare. agent-device connect owns Metro
preparation and disconnect stops the companion, so the cloud simulator
reaches this laptop's bundler without rn-iso running a second tunnel. Because
it is the same Metro process, the verify phase keeps working unchanged.
The dev-client deep link is composed here rather than left to agent-device's
Metro hint, which writes bare-RN RCT_jsLocation only and which a dev-client
ignores (callstack/agent-device#1245). `open <app> <url>` runs simctl openurl
verbatim, so rn-iso's own link works without the upstream fix.
Scope: iOS only, and no native device logs. agent-device captures with
--style compact while rn-iso's parser needs ndjson, so the collector cannot
port until that is opt-in upstream. The Metro half of the timeline is local
and unaffected.
Known gap, recorded in CLAUDE.md and the spec: gc and worktree remove do not
sweep remote sessions yet.1 parent 4707493 commit 2045a8b
15 files changed
Lines changed: 1160 additions & 37 deletions
File tree
- docs/specs
- packages/rn-iso
- skill
- src
- __tests__
- commands
- engine
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
| 345 | + | |
| 346 | + | |
346 | 347 | | |
347 | 348 | | |
348 | 349 | | |
| |||
353 | 354 | | |
354 | 355 | | |
355 | 356 | | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
356 | 380 | | |
357 | 381 | | |
358 | 382 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
73 | 87 | | |
74 | 88 | | |
75 | 89 | | |
| |||
111 | 125 | | |
112 | 126 | | |
113 | 127 | | |
114 | | - | |
115 | | - | |
116 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
117 | 135 | | |
118 | 136 | | |
119 | 137 | | |
| |||
169 | 187 | | |
170 | 188 | | |
171 | 189 | | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
176 | 205 | | |
177 | 206 | | |
178 | 207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
112 | 127 | | |
113 | 128 | | |
114 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | | - | |
85 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
86 | 87 | | |
87 | | - | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
0 commit comments