Another case of bad markup identified in Issue#549. Closing tags without having opening tags. Test cases also added.#568
Another case of bad markup identified in Issue#549. Closing tags without having opening tags. Test cases also added.#568boutell merged 3 commits intoapostrophecms:mainfrom techieKedar:develop
Conversation
…out having opening tags. Test cases also added.
|
Hello Team, Please review this change and let me know your comments. Thanks in advance! |
boutell
left a comment
boutell
left a comment
There was a problem hiding this comment.
I think the current code tolerates markup like this:
<div>
<p>
<p>
<p>
</div>
I think your change would break that which is too strict (a backwards compatibility break). Please add unit tests confirming if you think it won't be a problem.
Also:
<div>
<br />
<br />
<br />
</div>
I'm not sure if these self-closing tags go on the stack or not.
…rtant backward compatibility check for future changes.
|
Hello @boutell, Thank you for the feedback. Following is my response, point-wise. Markup like the following works fine, even after the change. I have added 2 test cases for the above markup as asked by you. For self-closing tags, Please let me know if anything else is needed from my end. Thanks, |
|
Thanks! |
|
Thank you @boutell 🙏 |
2 participants
Summary
Closes #549
What are the specific steps to test this change?
The snippets given in the issues should now work as expected.
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: