Give spans their proper parent in the plugin stack#4877
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
Some plugins may create their own span using the `serviceBuilder::instrument()` method. That method was only applying the span on the future returned by the inner service, but this meant that if plugin A created a span, then when pugin B created a span, its parent would not be span A but the parent of span A. By entiering the span before creating the future, we make sure that the span hierarchy is respected
Geal
force-pushed
the
geal/reparent-spans
branch
from
2fb0040 to
82b1f71
Compare
bnjjj
approved these changes
Mar 28, 2024
o0Ignition0o
approved these changes
Mar 28, 2024
BrynCooke
pushed a commit
that referenced
this pull request
Mar 29, 2024
Fix #4827 Some plugins may create their own span using the `serviceBuilder::instrument()` method. That method was only applying the span on the future returned by the inner service, but this meant that if plugin A created a span, then when pugin B created a span, its parent would not be span A but the parent of span A. By entiering the span before creating the future, we make sure that the span hierarchy is respected
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4827
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩