Skip to content

h2c support#3852

Merged
Geal merged 16 commits intodevfrom
geal/h2c
Sep 25, 2023
Merged

h2c support#3852
Geal merged 16 commits intodevfrom
geal/h2c

Conversation

@Geal
Copy link
Copy Markdown
Contributor

@Geal Geal commented Sep 19, 2023

Fix #3535

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

@github-actions

This comment has been minimized.

Sign in to view
@router-perf
Copy link
Copy Markdown

router-perf Bot commented Sep 19, 2023

CI performance tests

  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • large-request - Stress test with a 1 MB request payload
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • reload - Reload test over a long period of time at a constant rate of users
  • no-graphos - Basic stress test, no GraphOS.
  • xxlarge-request - Stress test with 100 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • const - Basic stress test that runs with a constant number of users

@Geal Geal marked this pull request as ready for review September 20, 2023 14:31
@Geal Geal requested review from a team, BrynCooke, SimonSapin and o0Ignition0o September 20, 2023 14:31
@Geal Geal requested a review from a team as a code owner September 21, 2023 08:44
@Geal Geal mentioned this pull request Sep 21, 2023
Open
shorgi
shorgi reviewed Sep 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shorgi shorgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyedit suggestions

Comment thread .changesets/feat_geal_h2c.md Outdated
Comment thread docs/source/configuration/traffic-shaping.mdx
o0Ignition0o
o0Ignition0o approved these changes Sep 25, 2023
View reviewed changes
Comment thread apollo-router/src/services/subgraph_service.rs Outdated
@Geal Geal enabled auto-merge (squash) September 25, 2023 13:35
@Geal Geal merged commit 7d45877 into dev Sep 25, 2023
@Geal Geal deleted the geal/h2c branch September 25, 2023 14:16
@abernix abernix mentioned this pull request Sep 26, 2023
Merged
abernix pushed a commit that referenced this pull request Sep 26, 2023
@Geal
remove broken migration (#3906)
951789f 
This follows up on #3852 but
removes the migration which was not practical to implement due to
limitations of our current migrator code. Unfortunately, this will mean
that users will need to transition from using the _experimental_ feature
(which is subject [our experimental release
stage](https://www.apollographql.com/docs/resources/product-launch-stages/))
to the GA release by updating their configuration accordingly.
@lrlna lrlna mentioned this pull request Sep 27, 2023
Merged
@ShaunPhillips ShaunPhillips mentioned this pull request May 30, 2024
Closed
@theJC theJC mentioned this pull request May 31, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonSapin SimonSapin Awaiting requested review from SimonSapin

@BrynCooke BrynCooke Awaiting requested review from BrynCooke

3 more reviewers

@shorgi shorgi shorgi left review comments

@bnjjj bnjjj bnjjj approved these changes

@o0Ignition0o o0Ignition0o o0Ignition0o approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Geal Geal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide support for subgraph connections to only be made with h2c (http2 cleartext/prior knowledge)

4 participants

@Geal @bnjjj @o0Ignition0o @shorgi