Coprocessors: Discard content-length sent by coprocessors.#3802
Merged
o0Ignition0o merged 8 commits intodevfrom Sep 13, 2023
Merged
Coprocessors: Discard content-length sent by coprocessors.#3802o0Ignition0o merged 8 commits intodevfrom
o0Ignition0o merged 8 commits intodevfrom
Conversation
ControlFlow::Break in coprocessors would lead to all response headers being directly forwarded back to the router, which would lead to content-length missmatch. This changeset discards content-length sent by the coprocessor.
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
bnjjj
reviewed
Sep 11, 2023
bnjjj
approved these changes
Sep 12, 2023
Contributor
bnjjj
left a comment
bnjjj
left a comment
There was a problem hiding this comment.
Small nits in the changelog
Co-authored-by: Coenen Benjamin <[email protected]>
garypen
reviewed
Sep 12, 2023
Contributor
garypen
left a comment
garypen
left a comment
There was a problem hiding this comment.
Maybe a bit neater to just filter out the content length.
Co-authored-by: Gary Pennington <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ControlFlow::Break in coprocessors would lead to all response headers being directly forwarded back to the router, which would lead to content-length missmatch. This changeset discards content-length sent by the coprocessor.