Skip to content
This repository was archived by the owner on Apr 13, 2023. It is now read-only.

chore(deps): Update peer dependency apollo-client to ^2.6.0#3064

Merged
hwillson merged 3 commits intoapollographql:masterfrom
brentertz:update-peer-dependencies
May 28, 2019
Merged

chore(deps): Update peer dependency apollo-client to ^2.6.0#3064
hwillson merged 3 commits intoapollographql:masterfrom
brentertz:update-peer-dependencies

Conversation

@brentertz
Copy link
Copy Markdown
Contributor

@brentertz brentertz commented May 23, 2019

Greetings. I am getting a peer dependency warning about apollo-client even though I have the latest version, v2.6.0, installed.

npm WARN [email protected] requires a peer of apollo-client@beta but none is installed. You must install peer dependencies yourself.

The apollo-client dist-tags are:

  • beta: 2.6.0-rc.3
  • latest: 2.6.0

I don't believe that we need to use the beta anymore now that it has been released. This PR simply updates the peer dependency version to ^2.6.0.

@apollo-cla
Copy link
Copy Markdown

apollo-cla commented May 23, 2019

@brentertz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

hwillson
hwillson approved these changes May 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @brentertz!

@hwillson hwillson merged commit 6ae6d1b into apollographql:master May 28, 2019
@hwillson hwillson mentioned this pull request May 28, 2019
Closed
hwillson added a commit that referenced this pull request Jun 3, 2019
@hwillson
Stop setting optional input to null when using the graphql HOC
19b284d 
Based on #3064.
@sarink
Copy link
Copy Markdown

sarink commented Jun 9, 2019 •
edited
Loading

my package.json

    "react-apollo": "^2.5.6",

the error

frontend_1  | npm WARN [email protected] requires a peer of apollo-client@beta but none is installed. You must install peer dependencies yourself.

and yet?
https://github.com/apollographql/react-apollo/blob/master/package.json

"version": "2.5.6",
"peerDependencies": {
  "apollo-client": "^2.6.0",
  ...

how is this still happening? 🤔

@brentertz
Copy link
Copy Markdown
Contributor Author

brentertz commented Jun 10, 2019

My guess would be that a new version of react-apollo has yet to be published.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hwillson hwillson hwillson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brentertz @apollo-cla @sarink @hwillson