This repository was archived by the owner on Apr 13, 2023. It is now read-only.
fixes variable default to null, where it should be undefiend#3056
Merged
hwillson merged 9 commits intoapollographql:masterfrom May 28, 2019
ZhengYuTay:master
Merged
fixes variable default to null, where it should be undefiend#3056hwillson merged 9 commits intoapollographql:masterfrom ZhengYuTay:master
hwillson merged 9 commits intoapollographql:masterfrom
ZhengYuTay:master
Conversation
|
@ZhengYuTay: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
@ZhengYuTay Thanks for the pull request. Fix is also for issue #2890. Hope we can merge this soon. |
hwillson
approved these changes
May 28, 2019
Member
hwillson
left a comment
hwillson
left a comment
There was a problem hiding this comment.
Thanks very much @ZhengYuTay!
|
@hwillson do you have any eta on when this fix will be released? |
|
@hwillson same question as @johansteffner asked, any idea when this be released? I have [email protected] and I still see this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1569.
The problem is when we did not implicitly set a nullable variable value to a mutation query. It will be set to null which is not intended.