This repository was archived by the owner on Apr 13, 2023. It is now read-only.
(fix) - correct Context types for useContext#3018
Merged
hwillson merged 7 commits intoapollographql:masterfrom May 28, 2019
Merged
(fix) - correct Context types for useContext#3018hwillson merged 7 commits intoapollographql:masterfrom
hwillson merged 7 commits intoapollographql:masterfrom
Conversation
JoviDeCroock
changed the title
hwillson
approved these changes
May 28, 2019
Member
hwillson
left a comment
hwillson
left a comment
There was a problem hiding this comment.
Thanks very much @JoviDeCroock!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3016
The type for useContext can't be derived like this, it's better to check for react.createContext to exist in Consumer then to derive the type like this.
Now
useContext(ApolloContext)does not return a TS error anymore.