This repository was archived by the owner on Apr 13, 2023. It is now read-only.
(fix) walking the tree when meeting a consumer#2558
Closed
JoviDeCroock wants to merge 6 commits intoapollographql:masterfrom
JoviDeCroock:bug/walkTree
Closed
(fix) walking the tree when meeting a consumer#2558JoviDeCroock wants to merge 6 commits intoapollographql:masterfrom JoviDeCroock:bug/walkTree
JoviDeCroock wants to merge 6 commits intoapollographql:masterfrom
JoviDeCroock:bug/walkTree
Conversation
ghost
added
the
blocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue was brought up in:
When reviewing this PR keep this in mind:
We should be able to convert all if checks to
react-isbut as a stated, i don't know why but we have to keep the old checks to make it work. I think something changed between 16.3 and 16.6 in the class for Consumers and Providers. This implying that they don't get properly recognised byreact-is.I tried replacing the isValidReactElement by one of reactis, but this also failed with the react16.3....
If you have any insight on this feel free to shoot.