This repository was archived by the owner on Apr 13, 2023. It is now read-only.
[Feature Request] MockedProvider can pass down props to child component#2482
Merged
hwillson merged 4 commits intoapollographql:masterfrom Mar 6, 2019
Merged
Conversation
…s as props for the child component
|
@miachenmtl: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
ghost
added
the
hwillson
approved these changes
Mar 6, 2019
Member
hwillson
left a comment
hwillson
left a comment
There was a problem hiding this comment.
Thanks for this @miachenmtl I've changed props to childProps for a bit of extra clarity, but other than that we're all set here. LGTM - thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
MockedProviderto accept apropsobject as prop, and to inject the key/values of the props object as props for the child component. This is useful for testing components using enzyme'ssetPropsmethod, which only runs on the root node.Checklist: