This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Remove allowSyntheticDefaultImports use#2438
Merged
Conversation
Typescript's `allowSyntheticDefaultImports` compiler option is something we'd like to start using, but I jumped the gun a bit by introducing it in 9a96519. Including it means that anyone who wants to use Typescript with React Apollo would have to also include it in their own local `tsconfig.json`, to be able to handle default imports properly. This is because we're also using Typescript's `es2015` module option, which means `allowSyntheticDefaultImports` has to be enabled explicitly. This commit removes `allowSyntheticDefaultImports` use, switching back to using a combination of `import * as X` and `require` syntax, to work with default imports. We'll re-introduce `allowSyntheticDefaultImports` use in React Apollo 3. Fixes #2433.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript's
allowSyntheticDefaultImportscompiler option is something we'd like to start using, but I jumped the gun a bit by introducing it in 9a96519. Including it means that anyone who wants to use Typescript with React Apollo would have to also include it in their own localtsconfig.json, to be able to handle default imports properly. This is because we're also using Typescript'ses2015module option, which meansallowSyntheticDefaultImportshas to be enabled explicitly.This PR removes
allowSyntheticDefaultImportsuse, switching back to using a combination ofimport * as Xandrequiresyntax, to work with default imports. We'll re-introduceallowSyntheticDefaultImportsuse in React Apollo 3.Fixes #2433.