Skip to content
This repository was archived by the owner on Apr 13, 2023. It is now read-only.

TVariables generic should be passed to ObservableQuery#2311

Merged
hwillson merged 4 commits intoapollographql:masterfrom
tgriesser:fix-types
Oct 2, 2018
Merged

TVariables generic should be passed to ObservableQuery#2311
hwillson merged 4 commits intoapollographql:masterfrom
tgriesser:fix-types

Conversation

@tgriesser
Copy link
Copy Markdown
Contributor

ObservableQuery<TData> -> ObservableQuery<TData, TVariables>

Related to changes in #2281, because variables was previously declared on the type it wasn't necessary before.

@ghost ghost added the typescript label Aug 27, 2018
Related to changes in apollographql#2281, because variables was
previously declared on the type it wasn't necessary before
@hwillson hwillson self-assigned this Sep 26, 2018
Copy link
Copy Markdown
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tgriesser!

@hwillson hwillson merged commit 5ea92e0 into apollographql:master Oct 2, 2018
@tgriesser tgriesser deleted the fix-types branch October 2, 2018 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants