fix: fetchPolicy support for Subscriptions#2298
fix: fetchPolicy support for Subscriptions#2298hwillson merged 8 commits intoapollographql:masterfrom
Conversation
|
@MatthieuLemoine: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Yes, I agree this is annoying. This is caused by the fact that our docs are auto published after a docs related PR has been merged. This can happen at any point, and isn't tied to a specific release, which is definitely confusing. Honestly I think the best way to address this (and several other repo workflow issues) is to move away from our current |
|
@hwillson This is a good idea, maybe the issue is less obvious for |
Hi! 👋
Apollo Client supports
fetchPolicyfor subscriptions but thefetchPolicyoption is not passed to the client in react-apollo.It can be useful when using
no-cacheto avoid automatic cache update & handle the update manually using the new onSubscriptionData.This PR just forwards the
fetchPolicyoption to apollo-client.PS: It could be nice to add some kind of note next to a feature in the documentation with the minimum version number needed to use it. Actually, I tried to set
fetchPolicytono-cachebecause I thought that I could useonSubscriptionDatato update the cache but it seems that it was only merged yesterday.