This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Avoid importing lodash directly#2045
Merged
hwillson merged 7 commits intoapollographql:masterfrom Aug 22, 2018
Merged
Conversation
Avoids unnecessarily importing all of `lodash`.
Avoids unnecessarily importing all of `lodash`.
|
@shahyar: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
rosskevin
suggested changes
Jul 14, 2018
Contributor
rosskevin
left a comment
rosskevin
left a comment
There was a problem hiding this comment.
Instead of import from this just needs to be changed to const = require and moved below the imports.
hwillson
approved these changes
Aug 22, 2018
Member
hwillson
left a comment
hwillson
left a comment
There was a problem hiding this comment.
Thanks for this @shahyar! We're going to be removing lodash completely in React Apollo 3.0, but for now let's get these changes in place. I've adjusted this PR a bit to include Typescript allowSyntheticDefaultImports / esModuleInterop changes at the same time, since they're relevant and we were going to add them anyways. Thanks!
williamboman
added a commit
to williamboman/react-apollo
that referenced
this pull request
Aug 29, 2018
* master: (112 commits) chore(deps): update dependency danger to v3.8.8 chore(deps): update dependency enzyme to v3.5.0 chore(deps): update dependency apollo-client to v2.4.1 chore(deps): update dependency apollo-cache-inmemory to v1.2.9 chore(deps): update dependency apollo-cache to v1.1.16 chore(deps): update dependency @types/react to v16.4.12 chore(deps): update dependency rollup-plugin-commonjs to v9.1.6 chore(deps): update dependency @types/node to v10.9.2 chore(deps): update dependency react-scripts to v1.1.5 chore(deps): update dependency ts-jest to v23.1.4 Avoid importing lodash directly (apollographql#2045) type graphql.options.skip HOC property (apollographql#2208) Replace duplicate ObservableQueryFields types defined in apollo-client (apollographql#2281) Make mock links mock parameter readonly (apollographql#2284) test-utils: allow passing a custom cache object to `MockedProvider` (apollographql#2254) Query: Fix data is undefined on error (apollographql#1983) Don't mutate options object when calculating variables from props (apollographql#1968) Feature: add onSubscriptionData callback to <Subscription> (apollographql#1966) Changelog update Example of a mutation including tests (apollographql#1998) ...
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems that this library might be accidentally including all of
lodash. It only needs to actually import two methods:includesandtimes.