re-implement support for @defer directive#2181
Closed
lilianammmatos wants to merge 1 commit intoapollographql:masterfrom
Closed
re-implement support for @defer directive#2181lilianammmatos wants to merge 1 commit intoapollographql:masterfrom
lilianammmatos wants to merge 1 commit intoapollographql:masterfrom
Conversation
lilianammmatos
requested review from
abernix and
martijnwalraven
as code owners
|
@lilianammmatos: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
What is the status of this PR ? Is or will it be any official support from the Apollo team? |
Author
|
Hi everyone! I, along with my colleague @robrichard, have been working on adding support for Relay-compatible I'll be closing this pull request as this approach is not compatible with Relay's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created this PR to get the
@deferchanges up-to-date withmasterbecause we'd like to start using this feature internally. I'm opening this PR in-case it's useful to any one else!This PR reimplements the proposed addition of
@defersupport to Apollo Server originally proposed by @clarencenpy. Full details of the proposed spec can be found here.TODO:
Via the original pull request:
Summary:
execute.jsfromgraphql.js. Functions that are untouched have been removed, and exported fromgraphqldirectly.execute()returnsExecutionResult | DeferredExecutionResult, the latter being if@deferhas been applied to any fields.DeferredExecutionResultwraps anExecutionResultcontaining the initial response, and an AsyncIterable.Testing:
@defer, while making sure that all the other tests are still passing. Tests are in__tests__/starWarsDefer-test.ts