Skip to content

Performance Impact of deprecated graphql-extensions #4889

@DrewML

Description

@DrewML

Profiling our Apollo Server setup, it looks like the deprecated graphql-extensions package is eating up a significant amount of time. Specifically, the whenResultIsFinished hook seems to be dominating.

I'm not seeing any warnings about deprecated extension usage during startup, so I was surprised to see the runtime cost of (graphql-extensions) is substantial.

image

Running tests locally, it seems like I can eliminate this cost entirely by adding a _extensionsEnabled property to my schema before being passed to the ApolloServer constructor, and that seems to bypass all the extension hooks.

If we're using Apollo Studio to capture and view metrics, are there any metrics we'll be missing by disabling extension support? As far as I can tell, all this functionality was migrated to the newer Plugin API a few months ago.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions