Fix type of ApolloServerPluginUsageReporting reportTimer (#7799)

stijnbe · web-flow · commit 63dc50fc65cd · 2023-12-11T13:14:41.000-08:00
Fixes #7798 In src/plugin/usageReporting/plugin.ts reportTimer is typed as NodeJS.Timer, it is actually a timeout, so using node 18> types it is incompatible with clearInterval()
diff --git a/.changeset/fair-squids-unite.md b/.changeset/fair-squids-unite.md
@@ -0,0 +1,5 @@
+---
+'@apollo/server': patch
+---
+
+Fix type of ApolloServerPluginUsageReporting reportTimer
diff --git a/packages/server/src/plugin/usageReporting/plugin.ts b/packages/server/src/plugin/usageReporting/plugin.ts
@@ -206,7 +206,7 @@ export function ApolloServerPluginUsageReporting<TContext extends BaseContext>(
           }
         | undefined;
 
-      let reportTimer: NodeJS.Timer | undefined;
+      let reportTimer: NodeJS.Timeout | undefined;
       if (!sendReportsImmediately) {
         reportTimer = setInterval(
           () => sendAllReportsAndReportErrors(),

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@apollo/server': patch
 +---
++
 +Fix type of ApolloServerPluginUsageReporting reportTimer
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ export function ApolloServerPluginUsageReporting<TContext extends BaseContext>(`
`206`	`206`	`}`
`207`	`207`	`\| undefined;`
`208`	`208`
`209`		`- let reportTimer: NodeJS.Timer \| undefined;`
	`209`	`+ let reportTimer: NodeJS.Timeout \| undefined;`
`210`	`210`	`if (!sendReportsImmediately) {`
`211`	`211`	`reportTimer = setInterval(`
`212`	`212`	`() => sendAllReportsAndReportErrors(),`