Rename option from disableValidation to dangerouslyDisableValidation

ganemone · ganemone · commit 4745ebed6977 · 2023-11-13T16:13:29.000-05:00
diff --git a/docs/source/api/apollo-server.mdx b/docs/source/api/apollo-server.mdx
@@ -201,7 +201,7 @@ An array containing custom functions to use as additional [validation rules](htt
 <tr>
 <td>
 
-##### `disableValidation`
+##### `dangerouslyDisableValidation`
 
 `Boolean`
 </td>
diff --git a/packages/apollo-server-core/src/ApolloServer.ts b/packages/apollo-server-core/src/ApolloServer.ts
@@ -959,7 +959,7 @@ export class ApolloServerBase<
       logger: this.logger,
       plugins: this.plugins,
       documentStore,
-      disableValidation: this.config.disableValidation,
+      dangerouslyDisableValidation: this.config.dangerouslyDisableValidation,
       context,
       parseOptions: this.parseOptions,
       ...this.requestOptions,
diff --git a/packages/apollo-server-core/src/graphqlOptions.ts b/packages/apollo-server-core/src/graphqlOptions.ts
@@ -62,7 +62,7 @@ export interface GraphQLServerOptions<
   persistedQueries?: PersistedQueryOptions;
   plugins?: ApolloServerPlugin[];
   documentStore?: DocumentStore | null;
-  disableValidation?: boolean;
+  dangerouslyDisableValidation?: boolean;
   parseOptions?: ParseOptions;
   nodeEnv?: string;
   allowBatchedHttpRequests?: boolean;
diff --git a/packages/apollo-server-core/src/requestPipeline.ts b/packages/apollo-server-core/src/requestPipeline.ts
@@ -91,7 +91,7 @@ export interface GraphQLRequestPipelineConfig<TContext> {
   ) => GraphQLResponse | null;
 
   plugins?: ApolloServerPlugin[];
-  disableValidation?: boolean;
+  dangerouslyDisableValidation?: boolean;
   documentStore?: DocumentStore | null;
 
   parseOptions?: ParseOptions;
@@ -258,7 +258,7 @@ export async function processGraphQLRequest<TContext extends BaseContext>(
       return await sendErrorResponse(syntaxError as GraphQLError, SyntaxError);
     }
 
-    if (config.disableValidation !== true) {
+    if (config.dangerouslyDisableValidation !== true) {
       const validationDidEnd = await dispatcher.invokeDidStartHook(
         'validationDidStart',
         requestContext as GraphQLRequestContextValidationDidStart<TContext>,
diff --git a/packages/apollo-server-core/src/runHttpQuery.ts b/packages/apollo-server-core/src/runHttpQuery.ts
@@ -274,7 +274,7 @@ export async function runHttpQuery(
     // passed in.
     cache: options.cache!,
     dataSources: options.dataSources,
-    disableValidation: options.disableValidation,
+    dangerouslyDisableValidation: options.dangerouslyDisableValidation,
     documentStore: options.documentStore,
 
     persistedQueries: options.persistedQueries,
diff --git a/packages/apollo-server-core/src/types.ts b/packages/apollo-server-core/src/types.ts
@@ -107,7 +107,7 @@ export interface Config<ContextFunctionParams = any> extends BaseConfig {
   stopOnTerminationSignals?: boolean;
   apollo?: ApolloConfigInput;
   nodeEnv?: string;
-  disableValidation?: boolean;
+  dangerouslyDisableValidation?: boolean;
   documentStore?: DocumentStore | null;
   csrfPrevention?: CSRFPreventionOptions | boolean;
   cache?: KeyValueCache | 'bounded';
diff --git a/packages/apollo-server-integration-testsuite/src/ApolloServer.ts b/packages/apollo-server-integration-testsuite/src/ApolloServer.ts
@@ -288,7 +288,7 @@ export function testApolloServer<AS extends ApolloServerBase>(
             stopOnTerminationSignals: false,
             nodeEnv: 'production',
             cache: 'bounded',
-            disableValidation: true,
+            dangerouslyDisableValidation: true,
           });
 
           const apolloFetch = createApolloFetch({ uri });
