Skip to content

Release changes from main into an alpha#13166

Merged
jerelmiller merged 2 commits intorelease-4.2from
jerel/changeset
Mar 4, 2026
Merged

Release changes from main into an alpha#13166
jerelmiller merged 2 commits intorelease-4.2from
jerel/changeset

Conversation

@jerelmiller
Copy link
Copy Markdown
Member

@jerelmiller jerelmiller commented Mar 4, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores

    • Added release documentation for upcoming patch versions.

  • Tests

    • Updated a test expectation to account for a TypeScript-checked error scenario so test typings align with current behavior.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 4, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 6df06f7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 4, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62fa9050-dff7-4421-9bae-b9ab494807db

📥 Commits

Reviewing files that changed from the base of the PR and between 453aa21 and 6df06f7.

📒 Files selected for processing (1)
  • src/core/__tests__/client.query/defaultOptions.test.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Compare Build Output
  • GitHub Check: Api-Extractor
  • GitHub Check: Are the types wrong
  • GitHub Check: Pull Request Prerelease
  • GitHub Check: Build and Test
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,js,jsx}: Use @apollo/client/*/internal paths for accessing internal APIs
Use RxJS observables for reactive programming patterns
Follow existing code style enforced by ESLint and Prettier

Files:

  • src/core/__tests__/client.query/defaultOptions.test.ts
🧠 Learnings (1)
📓 Common learnings 
Learnt from: CR
Repo: apollographql/apollo-client PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-02-19T17:01:54.257Z
Learning: Core Apollo Client implementation should be located in `src/core/` with key files including `ApolloClient.ts`, `ObservableQuery.ts`, and `QueryManager.ts`

Learnt from: phryneas
Repo: apollographql/apollo-client PR: 13132
File: integration-tests/type-tests/package.json:1-16
Timestamp: 2026-02-24T10:19:44.627Z
Learning: In integration-tests/type-tests/package.json, the apollo/client version is intentionally not kept in sync with the root package version because it gets overwritten during CI execution. Version mismatches in this file should not be flagged as issues.

Learnt from: CR
Repo: apollographql/apollo-client PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-02-19T17:01:54.257Z
Learning: All changes require a changeset created using `npx changeset`

Learnt from: CR
Repo: apollographql/apollo-client PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-02-19T17:01:54.257Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Use `apollo/client/*/internal` paths for accessing internal APIs
🔇 Additional comments (1)
src/core/__tests__/client.query/defaultOptions.test.ts (1)

33-33: Good use of @ts-expect-error for an intentional type-gap assertion.

The directive is scoped correctly and includes a clear reason, so this test remains explicit about known typing limitations without affecting runtime behavior.

📝 Walkthrough

Walkthrough

Adds a changeset file documenting a patch release for @apollo/client (versions 4.1.5 and 4.1.6) and updates a unit test to include a TypeScript expectation directive (// @ts-expect-error``) for an expected error field in src/core/__tests__/client.query/defaultOptions.test.ts.

Changes

Cohort / File(s) Summary
Changeset Configuration
\.changeset/empty-ads-shake.md		 Adds a new changeset entry documenting a patch release for @apollo/client with version bumps and release notes for 4.1.5 and 4.1.6.
Test Annotation
src/core/__tests__/client.query/defaultOptions.test.ts		 Adds a // @ts-expect-error`` TypeScript directive to the test expectation to acknowledge a missing error-field typing; no runtime or exported API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Release changes from main into an alpha' is vague and generic, using non-descriptive language that doesn't convey specific information about the actual changes (changeset file and test type annotation). Provide a more specific title that describes the main changes, such as 'Add changeset for patch release and update test type annotations' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jerel/changeset

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 4, 2026 •
edited
Loading 

npm i https://pkg.pr.new/apollographql/apollo-client/@apollo/client@13166

commit: 6df06f7

@jerelmiller jerelmiller merged commit 0537d97 into release-4.2 Mar 4, 2026
42 checks passed
@jerelmiller jerelmiller deleted the jerel/changeset branch March 4, 2026 23:49
@github-actions github-actions bot mentioned this pull request Mar 4, 2026
Merged
jerelmiller pushed a commit that referenced this pull request Mar 4, 2026
@github-actions
Version Packages (alpha) (#13167)
67bce6f 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to release-4.2, this
PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`release-4.2` is currently in **pre mode** so this branch has
prereleases rather than normal releases. If you want to exit
prereleases, run `changeset pre exit` on `release-4.2`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @apollo/[email protected]

### Patch Changes

- [#13166](#13166)
[`0537d97`](0537d97)
Thanks [@jerelmiller](https://github.com/jerelmiller)! - Release changes
in 4.1.5 and 4.1.6.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Mar 5, 2026
Draft
@coderabbitai coderabbitai bot mentioned this pull request Mar 18, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jerelmiller